[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/5] trace-events: Fix up source file comments
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 5/5] trace-events: Fix up source file comments |
Date: |
Fri, 07 Jun 2013 15:43:43 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 |
Am 07.06.2013 12:59, schrieb Markus Armbruster:
> They're all wrong since (at least) Paolo's big source tree
> reorganization. Need to shuffle some event declarations around to
> keep them under the correct source file comment.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> trace-events | 162
> ++++++++++++++++++++++++++++++++---------------------------
> 1 file changed, 87 insertions(+), 75 deletions(-)
>
> diff --git a/trace-events b/trace-events
> index e12d376..d95e903 100644
> --- a/trace-events
> +++ b/trace-events
> @@ -25,18 +25,14 @@
> #
> # The <format-string> should be a sprintf()-compatible format string.
>
> -# qemu-malloc.c
> -g_malloc(size_t size, void *ptr) "size %zu ptr %p"
> -g_realloc(void *ptr, size_t size, void *newptr) "ptr %p size %zu newptr %p"
> -g_free(void *ptr) "ptr %p"
> -
> -# osdep.c
> +# util/oslib-win32.c
> +# util/oslib-posix.c
[snip]
Thanks for taking time for this cleanup! I noticed before but haven't
found the time myself so far. ;)
If someone else feels like cleaning up, there's also quite a number of
header files which annotate prototypes with now wrong source files.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH 0/5] Trace fixes, Markus Armbruster, 2013/06/07
- [Qemu-devel] [PATCH 2/5] slavio_misc: Fix slavio_led_mem_readw/_writew tracepoints, Markus Armbruster, 2013/06/07
- [Qemu-devel] [PATCH 3/5] milkymist-minimac2: Fix minimac2_read/_write tracepoints, Markus Armbruster, 2013/06/07
- [Qemu-devel] [PATCH 4/5] trace-events: Drop unused events, Markus Armbruster, 2013/06/07
- [Qemu-devel] [PATCH 5/5] trace-events: Fix up source file comments, Markus Armbruster, 2013/06/07
- Re: [Qemu-devel] [PATCH 5/5] trace-events: Fix up source file comments,
Andreas Färber <=
- [Qemu-devel] [PATCH 1/5] cleanup-trace-events.pl: New, Markus Armbruster, 2013/06/07
- Re: [Qemu-devel] [PATCH 0/5] Trace fixes, Stefan Hajnoczi, 2013/06/10
- Re: [Qemu-devel] [PATCH 0/5] Trace fixes, Stefan Hajnoczi, 2013/06/10