[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 1/2] sheepdog: fix snapshot tag initialization
From: |
Liu Yuan |
Subject: |
[Qemu-devel] [PATCH 1/2] sheepdog: fix snapshot tag initialization |
Date: |
Thu, 6 Jun 2013 19:57:28 +0800 |
This is an old and obvious bug. We should pass snapshot_id to the
tag. Or simple command like 'qemu-img snapshot -a tag sheepdog:image' will fail
Cc: address@hidden
Cc: MORITA Kazutaka <address@hidden>
Cc: Kevin Wolf <address@hidden>
Cc: Stefan Hajnoczi <address@hidden>
Signed-off-by: Liu Yuan <address@hidden>
---
block/sheepdog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/sheepdog.c b/block/sheepdog.c
index 21a4edf..94218ac 100644
--- a/block/sheepdog.c
+++ b/block/sheepdog.c
@@ -2063,7 +2063,7 @@ static int sd_snapshot_goto(BlockDriverState *bs, const
char *snapshot_id)
if (snapid) {
tag[0] = 0;
} else {
- pstrcpy(tag, sizeof(tag), s->name);
+ pstrcpy(tag, sizeof(tag), snapshot_id);
}
ret = reload_inode(s, snapid, tag);
--
1.7.9.5
- [Qemu-devel] [PATCH 0/2] fix 'qemu-img snapshot -a' operation for sheepdog, Liu Yuan, 2013/06/06
- [Qemu-devel] [PATCH 1/2] sheepdog: fix snapshot tag initialization,
Liu Yuan <=
- [Qemu-devel] [PATCH 2/2] sheepdog: support 'qemu-img snapshot -a', Liu Yuan, 2013/06/06
- Re: [Qemu-devel] [PATCH 2/2] sheepdog: support 'qemu-img snapshot -a', Kevin Wolf, 2013/06/06
- Re: [Qemu-devel] [PATCH 2/2] sheepdog: support 'qemu-img snapshot -a', Liu Yuan, 2013/06/06
- Re: [Qemu-devel] [PATCH 2/2] sheepdog: support 'qemu-img snapshot -a', Kevin Wolf, 2013/06/07
- Re: [Qemu-devel] [PATCH 2/2] sheepdog: support 'qemu-img snapshot -a', Liu Yuan, 2013/06/07
- Re: [Qemu-devel] [PATCH 2/2] sheepdog: support 'qemu-img snapshot -a', Kevin Wolf, 2013/06/07
- Re: [Qemu-devel] [PATCH 2/2] sheepdog: support 'qemu-img snapshot -a', Liu Yuan, 2013/06/07
- Re: [Qemu-devel] [PATCH 2/2] sheepdog: support 'qemu-img snapshot -a', Kevin Wolf, 2013/06/07
- Re: [Qemu-devel] [PATCH 2/2] sheepdog: support 'qemu-img snapshot -a', Liu Yuan, 2013/06/07