[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/2] vhost-scsi: fix k->set_guest_notifiers()
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/2] vhost-scsi: fix k->set_guest_notifiers() NULL dereference |
Date: |
Mon, 03 Jun 2013 11:07:22 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 |
Il 03/06/2013 10:58, Stefan Hajnoczi ha scritto:
> Coverity picked up a copy-paste bug. In vhost_scsi_start() we check for
> !k->set_guest_notifiers and error out. The check probably got copied
> but instead of erroring we actually use the function pointer!
Exactly. :)
Applied to scsi branch, thanks.
Paolo
> Cc: Nicholas Bellinger <address@hidden>
> Cc: Asias He <address@hidden>
> Cc: address@hidden
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> hw/scsi/vhost-scsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c
> index d7a1c33..785e93f 100644
> --- a/hw/scsi/vhost-scsi.c
> +++ b/hw/scsi/vhost-scsi.c
> @@ -123,7 +123,7 @@ static void vhost_scsi_stop(VHostSCSI *s)
> VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(qbus);
> int ret = 0;
>
> - if (!k->set_guest_notifiers) {
> + if (k->set_guest_notifiers) {
> ret = k->set_guest_notifiers(qbus->parent, s->dev.nvqs, false);
> if (ret < 0) {
> error_report("vhost guest notifier cleanup failed: %d\n",
> ret);
>