Re: [Qemu-devel] [PATCH 11/21] memory: iommu support

[Richard Henderson]

On 05/30/2013 02:16 PM, Paolo Bonzini wrote:
>  struct MemoryRegion {
>      /* All fields are private - violators will be prosecuted */
>      const MemoryRegionOps *ops;
> +    const MemoryRegionIOMMUOps *iommu_ops;
>      void *opaque;
>      MemoryRegion *parent;
...
> +void memory_region_init_iommu(MemoryRegion *mr,
> +                              MemoryRegionIOMMUOps *ops,
> +                              const char *name,
> +                              uint64_t size)
> +{

Surely the incoming ops pointer should be const too?  Otherwise,

Reviewed-by: Richard Henderson <address@hidden>


r~