qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V3 0/4] qapi and snapshot code clean up in block


From: Wenchao Xia
Subject: Re: [Qemu-devel] [PATCH V3 0/4] qapi and snapshot code clean up in block layer
Date: Fri, 31 May 2013 21:04:10 +0800
User-agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20130509 Thunderbird/17.0.6

于 2013-5-30 10:41, Wenchao Xia 写道:
于 2013-5-27 23:41, Kevin Wolf 写道:
Am 25.05.2013 um 05:09 hat Wenchao Xia geschrieben:
These patches are the common part of my hmp/qmp block query series
and Pavel's
qmp snapshot command converion series. It mainly does following things:
1 move snapshot related code to block/snapshot.c, qmp and info
dumping code to
block/qapi.c.
2 better info dumping function to get rid of buffer, avoid string
truncation.

Posted comments on patch 1 and 4.

Patches 2 and 3 are:
Reviewed-by: Kevin Wolf <address@hidden>

   It seems nothing need change, Kevin, do you think it can be merged?

  This serial blocks mine and Pavel's work, anything need to be
improved? Respin with
-typedef int (*fprintf_function)(FILE *f, const char *fmt, ...)
+typedef int (*fprintf_function)(void *out, const char *fmt, ...)
?
--
Best Regards

Wenchao Xia




reply via email to

[Prev in Thread] Current Thread [Next in Thread]