[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 07/11] blockdev: rename BlkTransactionStates
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v5 07/11] blockdev: rename BlkTransactionStates to singular |
Date: |
Thu, 30 May 2013 16:55:08 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 |
On 05/30/2013 06:34 AM, Stefan Hajnoczi wrote:
> The QMP 'transaction' command keeps a list of in-flight transactions.
> The transaction state structure is called BlkTransactionStates even
> though it only deals with a single transaction. The only plural thing
> is the linked list of transaction states.
>
> I find it confusing to call the single structure "States". This patch
> renames it to "State", just like BlockDriverState is singular.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> blockdev.c | 104
> ++++++++++++++++++++++++++++++-------------------------------
> 1 file changed, 52 insertions(+), 52 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v5 00/11] block: drive-backup live backup command, Stefan Hajnoczi, 2013/05/30
- [Qemu-devel] [PATCH v5 08/11] blockdev: allow BdrvActionOps->commit() to be NULL, Stefan Hajnoczi, 2013/05/30
- [Qemu-devel] [PATCH v5 09/11] blockdev: add DriveBackup transaction, Stefan Hajnoczi, 2013/05/30
- [Qemu-devel] [PATCH v5 10/11] blockdev: add Abort transaction, Stefan Hajnoczi, 2013/05/30
- [Qemu-devel] [PATCH v5 04/11] blockdev: drop redundant proto_drv check, Stefan Hajnoczi, 2013/05/30
- [Qemu-devel] [PATCH v5 07/11] blockdev: rename BlkTransactionStates to singular, Stefan Hajnoczi, 2013/05/30
- Re: [Qemu-devel] [PATCH v5 07/11] blockdev: rename BlkTransactionStates to singular,
Eric Blake <=
- [Qemu-devel] [PATCH v5 05/11] blockdev: use bdrv_getlength() in qmp_drive_mirror(), Stefan Hajnoczi, 2013/05/30
- [Qemu-devel] [PATCH v5 02/11] block: add bdrv_add_before_write_notifier(), Stefan Hajnoczi, 2013/05/30
- [Qemu-devel] [PATCH v5 11/11] qemu-iotests: add 055 drive-backup test case, Stefan Hajnoczi, 2013/05/30
- [Qemu-devel] [PATCH v5 01/11] notify: add NotiferWithReturn so notifier list can abort, Stefan Hajnoczi, 2013/05/30
- [Qemu-devel] [PATCH v5 06/11] block: add drive-backup QMP command, Stefan Hajnoczi, 2013/05/30
- [Qemu-devel] [PATCH v5 03/11] block: add basic backup support to block driver, Stefan Hajnoczi, 2013/05/30