[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qdev: don't add typename to fw_dev_path when ge
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] qdev: don't add typename to fw_dev_path when get_fw_dev_path isn't implemented |
Date: |
Tue, 28 May 2013 12:30:42 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 |
Il 28/05/2013 12:25, Amos Kong ha scritto:
> Currently we add typename to fw_dev_path if virtio-bus
> doesn't have get_fw_dev_path implementation, the fw_dev_path
> passed to seabios is not expected, the typename is redundant.
> It causes that bootindex parameter of scsi device doesn't work.
>
> This patch changes the qdev_get_fw_dev_path_helper() to add
> nothing if device doesn't have get_fw_dev_path implementation.
This is not enough, because it would change behavior for other buses
that do not have get_fw_dev_path. You also need to add a default
implementation of the callback.
> Signed-off-by: Paolo Bonzini <address@hidden>
You don't need my Signed-off-by. On the other hand, you should Cc
address@hidden
Paolo
> Signed-off-by: Amos Kong <address@hidden>
> ---
> hw/core/qdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/core/qdev.c b/hw/core/qdev.c
> index 6985ad8..150255d 100644
> --- a/hw/core/qdev.c
> +++ b/hw/core/qdev.c
> @@ -515,7 +515,7 @@ static int qdev_get_fw_dev_path_helper(DeviceState *dev,
> char *p, int size)
> l += snprintf(p + l, size - l, "%s", d);
> g_free(d);
> } else {
> - l += snprintf(p + l, size - l, "%s",
> object_get_typename(OBJECT(dev)));
> + return l;
> }
> }
> l += snprintf(p + l , size - l, "/");
>