Re: [Qemu-devel] [PATCH v4 00/12] target-i386: remove some macros

[Andreas Färber]

Am 28.05.2013 10:19, schrieb li guang:
> remove macros EAX, EBX, ECX, EDX, EBP, ESP, ESI, EDI, EIP, DF
> as suggested by Richard Henderson <address@hidden>
> 
> v4: fix alignment issue in patch 6.

Thanks, I reviewed patch 6, the rest was already Reviewed-by, so

> 
> Li Guang (12)
>          target-i386/helper: remove EAX macro
>          target-i386/helper: remove EBX macro
>          target-i386/helper: remove ECX macro
>          target-i386/helper: remove EDX macro
>          target-i386/helper: remove EBP macro
>          target-i386/helper: remove ESP macro
>          target-i386/helper: remove ESI macro
>          target-i386/helper: remove EDI macro
>          target-i386/helper: remove EIP macro
>          target-i386/helper: remove DF macro
>          target-i386/helper: remove redundant env->eip assignment
>          target-i386: fix over 80 chars warnings

Reviewed-by: Andreas Färber <address@hidden>

Thanks,
Andreas

> cpu-exec.c                |   4 ++--
> target-i386/cc_helper.c   |   2 +-
> target-i386/cpu.h         |  24 -
> target-i386/excp_helper.c |   2 +-
> target-i386/int_helper.c  |  86
> ++++++++++++++++++++++----------------------
> target-i386/mem_helper.c  |  24 +++---
> target-i386/misc_helper.c | 107 +++---
> target-i386/seg_helper.c  | 182 +++---
> target-i386/smm_helper.c  |  64 +++---
> target-i386/svm_helper.c  |  66 ++++++++--------
> 10 files changed, 280 insertions(+), 281 deletions(-)

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg