qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in port


From: Michael S. Tsirkin
Subject: Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code
Date: Sun, 26 May 2013 23:02:51 +0300

On Sun, May 26, 2013 at 08:53:33PM +0200, Paolo Bonzini wrote:
> Il 26/05/2013 20:37, Michael S. Tsirkin ha scritto:
> >> > I don't like defining __-prefixed types.  Can we preprocess
> >> > linux-headers to avoid usage of __u8/16/32/64, and to
> >> > s,linux/types.h,stdint.h, ?
> >> > 
> >> > Paolo
> > Let's not be purists, and do the practical thing.
> > 
> > When I suggested this you didn't like it:
> >>> >> I can think of two ways:
> >>> >>     - strip linux/types.h in update_headers
> >>> >>     - add a stub linux/types.h for non linux platforms
> >> >
> >> >The latter, using stdint.h types, would be fine.
> 
> My fault.  I should have looked at linux/types.h (actually asm-generic/).
> 
> Paolo

Not really, __uX appear in the headers that were posted.
What I'm saying is - a chance of a conflict is very remote,
if it happens it's a build failure so easy to debug.

-- 
MST




reply via email to

[Prev in Thread] Current Thread [Next in Thread]