[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/8] pci: Cleanup configuration for pci-hotplug.
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [PATCH 1/8] pci: Cleanup configuration for pci-hotplug.c |
Date: |
Thu, 23 May 2013 22:23:13 +1000 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, May 23, 2013 at 02:11:35PM +0300, Michael S. Tsirkin wrote:
> On Thu, May 09, 2013 at 10:31:05AM +1000, David Gibson wrote:
[snip]
> > diff --git a/hw/pci/pci-hotplug-old.c b/hw/pci/pci-hotplug-old.c
> > new file mode 100644
> > index 0000000..724a80b
> > --- /dev/null
> > +++ b/hw/pci/pci-hotplug-old.c
>
> Please use git format-patch -M so renames are
> properly shown. I can't see whether anything changed here.
Ah, sorry. Forgot that wasn't the default.
> > @@ -0,0 +1,290 @@
> > +/*
> > + * QEMU PCI hotplug support
>
> I don't particularly mind whether it's called pci-hotplug or
> pci-hotplug-old, but I'm prepared to go with you on this.
> However, what we really should do is fix the comment
> to match reality.
Good point.
> I think this needs two commits:
> - fix comment
> - rename
>
> to make format-patch -M detect this as a rename
Hrm, I think it should detect the rename, even with a change to the
comment. But I'll check to make sure, and split if necessary.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: Digital signature
- [Qemu-devel] [PATCH 5/8] pci: Replace pci_find_domain() with more general pci_root_bus_path(), (continued)
- [Qemu-devel] [PATCH 5/8] pci: Replace pci_find_domain() with more general pci_root_bus_path(), David Gibson, 2013/05/08
- Re: [Qemu-devel] [PATCH 5/8] pci: Replace pci_find_domain() with more general pci_root_bus_path(), Michael S. Tsirkin, 2013/05/23
- Re: [Qemu-devel] [PATCH 5/8] pci: Replace pci_find_domain() with more general pci_root_bus_path(), David Gibson, 2013/05/23
- Re: [Qemu-devel] [PATCH 5/8] pci: Replace pci_find_domain() with more general pci_root_bus_path(), Paolo Bonzini, 2013/05/23
- Re: [Qemu-devel] [PATCH 5/8] pci: Replace pci_find_domain() with more general pci_root_bus_path(), Michael S. Tsirkin, 2013/05/23
- Re: [Qemu-devel] [PATCH 5/8] pci: Replace pci_find_domain() with more general pci_root_bus_path(), Paolo Bonzini, 2013/05/23
- Re: [Qemu-devel] [PATCH 5/8] pci: Replace pci_find_domain() with more general pci_root_bus_path(), Michael S. Tsirkin, 2013/05/23
- Re: [Qemu-devel] [PATCH 5/8] pci: Replace pci_find_domain() with more general pci_root_bus_path(), David Gibson, 2013/05/24
[Qemu-devel] [PATCH 1/8] pci: Cleanup configuration for pci-hotplug.c, David Gibson, 2013/05/08
Re: [Qemu-devel] [0/8] Clean up PCI code to allow for multiple root buses, Michael S. Tsirkin, 2013/05/14
Re: [Qemu-devel] [0/8] Clean up PCI code to allow for multiple root buses, Michael S. Tsirkin, 2013/05/23