Re: [Qemu-devel] [RFC 2/2] qemu-log: Interrupt the GDB session on guest-errors

[Edgar E. Iglesias]

On Wed, May 22, 2013 at 11:45:46AM +0100, Peter Maydell wrote:
> On 22 May 2013 11:38,  <address@hidden> wrote:
> > From: "Edgar E. Iglesias" <address@hidden>
> > @@ -45,6 +46,25 @@ void qemu_log_mask(int mask, const char *fmt, ...)
> >          vfprintf(qemu_logfile, fmt, ap);
> >      }
> >      va_end(ap);
> > +
> > +    /*
> > +     * Break the GDB session (if connected) so that the user can inspect 
> > the
> > +     * guest state.
> > +     *
> > +     * TODO: Consider conditionalizing this on a cmdline option.
> > +     */
> 
> This is definitely way too intrusive to be unconditional -- it can
> happen really frequently (for instance Linux on OMAP3 will access
> a nonexistent register every time it takes an interrupt).

Ye, I figured this would be the case.

Maybe a qemu monitor flag controllable from the gdb client itself might be
the most useful, default off. Then one can turn the breaks on/off on
the fly while debugging.

monitor gdb_break_on_guest_errors or something like that.

Cheers,
Edgar