Re: [Qemu-devel] [PATCH 1/3] chardev: Make consistent with udp device for new qapi backend

[Eric Blake]

On 05/20/2013 12:51 AM, Lei Li wrote:
> When register and open a chardev udp, the backend name should be udp 
> not dgram, and we do not have backend dgram in the chardev list. This
> patch makes the new qapi udp backend consistent with the original
> udp device.
> 
> Signed-off-by: Lei Li <address@hidden>
> ---
>  qapi-schema.json |    8 ++++----
>  qemu-char.c      |   10 +++++-----
>  2 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 199744a..9302e7d 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -3210,7 +3210,7 @@
>                                       '*telnet'  : 'bool' } }
>  
>  ##
> -# @ChardevDgram:
> +# @ChardevUdp:

This rename is okay,

> @@ -3310,7 +3310,7 @@
>                                         'parallel': 'ChardevHostdev',
>                                         'pipe'   : 'ChardevHostdev',
>                                         'socket' : 'ChardevSocket',
> -                                       'dgram'  : 'ChardevDgram',
> +                                       'udp'    : 'ChardevUdp',

but this rename would be ABI-visible if it doesn't make the release.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature