[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-1.5] portability: pty.h is glibc-specific
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH for-1.5] portability: pty.h is glibc-specific |
Date: |
Tue, 14 May 2013 21:28:25 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 |
On 05/14/13 18:35, Paolo Bonzini wrote:
> Il 14/05/2013 18:15, Brad Smith ha scritto:
>> On Tue, May 14, 2013 at 04:10:56PM -0000, Anthony Liguori wrote:
>>> Applied. Thanks.
>>>
>>> Regards,
>>>
>>> Anthony Liguori
>>
>> The patch was not updated to take into consideration my comment from bug
>> 1177774 so
>> what was commited is just as broken as before the patch.
>
> Just send a followup yourself. You and Blue Swirl are the only users of
> QEMU on OpenBSD as far as we know, so anything that you do not do
> yourself is just best-effort.
Not to argue with this, just a general note: most of whatever is
portable from the terminal IO interfaces belongs into <termios.h> indeed.
http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/termios.h.html
Traditionally nonportable stuff related to pty allocation and
master-slave pairing has been "recently" standardized as well (as in,
SUSv3 / UNIX 03):
http://pubs.opengroup.org/onlinepubs/9699919799/functions/posix_openpt.html
(+grantpt, ptsname, unlockpt; they seem to date back to SUSv1 / UNIX 95)
CC'ing Eric for the obligatory POSIX sanity check... :)
Laszlo
Re: [Qemu-devel] [PATCH for-1.5] portability: pty.h is glibc-specific, Brad Smith, 2013/05/14
Re: [Qemu-devel] [PATCH for-1.5] portability: pty.h is glibc-specific, Peter Maydell, 2013/05/14