[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 04/11] curl: fix curl_open
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v2 04/11] curl: fix curl_open |
Date: |
Tue, 14 May 2013 10:13:31 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, May 14, 2013 at 10:26:23AM +0800, Fam Zheng wrote:
> + if (!strncmp(s->url, "http://", strlen("http://")) && !s->accept_range) {
> + strncpy(state->errmsg, "Server not supporting range.",
> CURL_ERROR_SIZE);
Please use pstrcpy(), it always NUL-terminates. strncpy(3) does not
when the buffer size is reached.
Also, what happens when the URL is given in uppercase?
HTTP://GOOGLE.COM/
- [Qemu-devel] [PATCH v2 00/11] curl: fix curl read, Fam Zheng, 2013/05/13
- [Qemu-devel] [PATCH v2 01/11] curl: introduce CURLSockInfo to BDRVCURLState., Fam Zheng, 2013/05/13
- [Qemu-devel] [PATCH v2 02/11] curl: change magic number to macro, Fam Zheng, 2013/05/13
- [Qemu-devel] [PATCH v2 03/11] curl: change curl_multi_do to curl_fd_handler, Fam Zheng, 2013/05/13
- [Qemu-devel] [PATCH v2 04/11] curl: fix curl_open, Fam Zheng, 2013/05/13
- Re: [Qemu-devel] [PATCH v2 04/11] curl: fix curl_open,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH v2 05/11] curl: add timer to BDRVCURLState, Fam Zheng, 2013/05/13
- [Qemu-devel] [PATCH v2 06/11] curl: introduce CURLDataCache, Fam Zheng, 2013/05/13
- [Qemu-devel] [PATCH v2 07/11] curl: make use of CURLDataCache., Fam Zheng, 2013/05/13
- [Qemu-devel] [PATCH v2 08/11] curl: use list to store CURLState, Fam Zheng, 2013/05/13
- [Qemu-devel] [PATCH v2 09/11] curl: release everything on curl_close, Fam Zheng, 2013/05/13
- [Qemu-devel] [PATCH v2 10/11] curl: add cache quota., Fam Zheng, 2013/05/13
- [Qemu-devel] [PATCH v2 11/11] curl: introduce ssl_no_cert runtime option., Fam Zheng, 2013/05/13
- Re: [Qemu-devel] [PATCH v2 00/11] curl: fix curl read, Stefan Hajnoczi, 2013/05/14