[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] blockdev: Rename BlockdevAction -> TransactionA
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH] blockdev: Rename BlockdevAction -> TransactionAction |
|
Date: |
Mon, 13 May 2013 16:53:22 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, May 13, 2013 at 06:51:06AM -0600, Eric Blake wrote:
> On 05/13/2013 02:46 AM, Kevin Wolf wrote:
> > There's no reason to restrict transactions to operations related to
> > block devices, so rename the type now before schema introspection stops
> > us from doing so.
> >
> > Signed-off-by: Kevin Wolf <address@hidden>
> > ---
> > blockdev.c | 22 +++++++++++-----------
> > qapi-schema.json | 8 ++++----
> > 2 files changed, 15 insertions(+), 15 deletions(-)
>
> Reviewed-by: Eric Blake <address@hidden>
>
> However,
>
> > #
> > # List of:
> > -# @BlockdevAction: information needed for the device snapshot
> > +# @TransactionAction: information needed for the device snapshot
>
> Is this comment now out of date?
kwolf: feel free to send a v2 and I'll replace what I merged.