[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/4] kvm-all: add kvm_ioctl, kvm_vm_ioctl, kvm_v
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 1/4] kvm-all: add kvm_ioctl, kvm_vm_ioctl, kvm_vcpu_ioctl tracepoints |
Date: |
Wed, 8 May 2013 10:48:51 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, May 03, 2013 at 02:12:14PM +0200, Andreas Färber wrote:
> > +# kvm-all.c
> > +kvm_ioctl(int type, void *arg) "type %d, arg %p"
> > +kvm_vm_ioctl(int type, void *arg) "type %d, arg %p"
> > +kvm_vcpu_ioctl(int cpu_index, int type, void *arg) "cpu_index %d, type %d,
> > arg %p"
>
> Sorry that I'm just seeing this patch now (wasn't CC'ed), but I wonder
> whether cpu_index is the best thing to trace here? Can we still change
> trace event API or would we have to nack/change now?
Trace events are not stable. We can change them.
STefan
- [Qemu-devel] [PULL 0/4] Tracing patches, Stefan Hajnoczi, 2013/05/03
- [Qemu-devel] [PATCH 1/4] kvm-all: add kvm_ioctl, kvm_vm_ioctl, kvm_vcpu_ioctl tracepoints, Stefan Hajnoczi, 2013/05/03
- [Qemu-devel] [PATCH 2/4] kvm-all: add kvm_run_exit tracepoint, Stefan Hajnoczi, 2013/05/03
- [Qemu-devel] [PATCH 3/4] trace: Add ftrace tracing backend, Stefan Hajnoczi, 2013/05/03
- [Qemu-devel] [PATCH 4/4] trace: document ftrace backend, Stefan Hajnoczi, 2013/05/03