Re: [Qemu-devel] [PATCH 00/40] Memory-related changes sneak peek for 1.6

[Paolo Bonzini]

Il 07/05/2013 16:46, Peter Maydell ha scritto:
> On 7 May 2013 15:16, Paolo Bonzini <address@hidden> wrote:
>> These patches are also at git://github.com/bonzini/qemu.git, branch
>> iommu.
> 
> A number of the patches in this series have checkpatch issues,
> mostly but not exclusively over-long lines.

ERROR: space prohibited before open square bracket '['
#2157: FILE: hw/ppc/spapr_iommu.c:106:
+        .perm = { [0] = tce & SPAPR_TCE_RO, [1] = tce & SPAPR_TCE_WO },

False positive.


ERROR: do not use assignment in if condition
#3313: FILE: hw/ide/ahci.c:660:
+    if (!(prdt = dma_memory_map(ad->hba->as, prdt_addr, &prdt_len,

Pre-existing, in a large mechanical patch.  Will not fix.


ERROR: spaces required around that '?' (ctx:VxV)
#4298: FILE: memory.c:1600:
+    as->name = g_strdup(name?name:"anonymous");
                             ^

ERROR: spaces required around that ':' (ctx:VxV)
#4298: FILE: memory.c:1600:
+    as->name = g_strdup(name?name:"anonymous");
                                  ^

Will fix.


ERROR: need consistent spacing around '*' (ctx:WxV)
#4399: FILE: memory.c:1044:
+Object *memory_region_owner(MemoryRegion *mr)
        ^

False positive.


ERROR: "foo * bar" should be "foo *bar"
#5224: FILE: hw/display/cirrus_vga.c:2809:
+static void cirrus_init_common(CirrusVGAState * s, int device_id,

Will fix.

Paolo