[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/6] xhci: add vmstate
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 5/6] xhci: add vmstate |
Date: |
Tue, 07 May 2013 16:14:01 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 |
On 05/07/13 16:06, Michael S. Tsirkin wrote:
>> +#if 0
> should have a comment explaining why is this
> commented out.
> Or just drop this section.
>
>> > + /* event queue (used if ring is full) */
>> > + VMSTATE_BOOL(er_full, XHCIInterrupter),
>> > + VMSTATE_UINT32(ev_buffer_put, XHCIInterrupter),
>> > + VMSTATE_UINT32(ev_buffer_get, XHCIInterrupter),
>> > + /* TODO */ XHCIEvent ev_buffer[EV_QUEUE];
>> > +#endif
>> >
xhci buffers events in case the ring is full. Doesn't happen under
normal circumstances, thats why I didn't bother finishing it (yet).
Doing that and stress-testing xhci migration are the todo list items
before I'll go merge this series.
cheers,
Gerd
[Qemu-devel] [PATCH 2/6] xhci: add XHCISlot->addressed, Gerd Hoffmann, 2013/05/07
[Qemu-devel] [PATCH 6/6] [debug] xhci: remove unmigratable flag, Gerd Hoffmann, 2013/05/07