qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V4 1/5] block: package preparation code in qmp_t


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH V4 1/5] block: package preparation code in qmp_transaction()
Date: Fri, 03 May 2013 08:18:53 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5

On 05/01/2013 08:26 PM, Wenchao Xia wrote:
> The code before really committing is moved into a function. Most
> code are simply moved from qmp_transaction(), except that on fail it

s/are/is/

> just return now. Other code such as input parsing is not touched,

s/return/returns/

> to make it easier in review.
> 
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
>  blockdev.c |  139 
> +++++++++++++++++++++++++++++++++---------------------------
>  1 files changed, 77 insertions(+), 62 deletions(-)
> 

Assuming the maintainer can correct commit messages without needing a v5.

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]