Re: [Qemu-devel] [PATCH] virtio-net: count VIRTIO_NET_F_MAC when calculating config_len

[Cornelia Huck]

On Mon, 29 Apr 2013 23:09:52 +0300
"Michael S. Tsirkin" <address@hidden> wrote:

> On Mon, Apr 29, 2013 at 08:45:50PM +0200, KONRAD Frédéric wrote:

> > Maybe we can move the two firsts line in the virtio_net_pci_init before the
> > init if they are usefull in the
> > config_size computing:
> > 
> > 
> >                 proxy->host_features |= 0x1 << VIRTIO_F_NOTIFY_ON_EMPTY;
> >                 proxy->host_features |= 0x1 << VIRTIO_F_BAD_FEATURE;
> 
> Bus can set VIRTIO_F_NOTIFY_ON_EMPTY and VIRTIO_F_BAD_FEATURE
> later, this is not going to affect anything.
> 
> Reason is, VIRTIO_F_NOTIFY_ON_EMPTY and VIRTIO_F_BAD_FEATURE
> are compatibility hacks which is why we dont
> have them for s390. It's probably a bug that
> we have them for virtio-ccw.
> 

Yes, probably (I used virtio-pci as my inspiration a lot...)

I'll check whether killing this works as expected.