[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/5] block: initial VHDX driver support frame
From: |
Jeff Cody |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/5] block: initial VHDX driver support framework - supports open and probe |
Date: |
Mon, 29 Apr 2013 13:25:13 -0400 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Sun, Apr 28, 2013 at 03:29:14PM +0800, Fam Zheng wrote:
> > +static void cpu_to_leguids(ms_guid *guid)
> > +{
> > + cpu_to_le32s(&guid->data1);
> > + cpu_to_le16s(&guid->data2);
> > + cpu_to_le16s(&guid->data3);
> > +}
>
> This one seems used in 5/5 only, so this patch fails compiling (defined
> but not used with -Werror=unused-function). Maybe move to 5/5?
>
Thanks. Yes, that should be in patch 5 (git rebase user error there),
which means this will go away completely for v3.
[Qemu-devel] [PATCH v2 5/5] block: add header update capability for VHDX images., Jeff Cody, 2013/04/23
Re: [Qemu-devel] [PATCH v2 5/5] block: add header update capability for VHDX images., Fam Zheng, 2013/04/28
[Qemu-devel] [PATCH v2 4/5] block: add read-only support to VHDX image format., Jeff Cody, 2013/04/23