[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/5] block: vhdx header for the QEMU support
From: |
Jeff Cody |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/5] block: vhdx header for the QEMU support of VHDX images |
Date: |
Wed, 24 Apr 2013 08:34:25 -0400 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Apr 24, 2013 at 02:31:27PM +0200, Stefan Hajnoczi wrote:
> On Tue, Apr 23, 2013 at 10:24:21AM -0400, Jeff Cody wrote:
> > +/* ---- HEADER SECTION STRUCTURES ---- */
> > +
> > +/* Important note: these structures are as defined in the VHDX
> > specification,
> > + * including byte order and size. However, without being packed
> > structures,
> > + * they will not match 1:1 data read from disk. Rather than use
> > potentially
> > + * non-portable packed structures, data is copied from read buffers into
> > + * the structures below. However, for reference, please refrain from
> > + * modifying these structures to something that does not represent the
> > spec */
>
> Outdated comment? The patch uses QEMU_PACKED.
>
Yes, outdated comment, thanks.
> > +/* Header for the region table block */
> > +#define VHDX_RT_MAGIC 0x69676572 /* 'regi ' */
>
> Not worth respinnning, but should be 'regi' (4 bytes).
Per Kevin's comments, I am removing all the _MAGIC's from the
headers anyway, and using memcmp against the strings in the source
file. So I'll take care of the outdated comment as well then.
- [Qemu-devel] [PATCH v2 0/5] Initial VHDX support, Jeff Cody, 2013/04/23
- [Qemu-devel] [PATCH v2 1/5] qemu: add castagnoli crc32c checksum algorithm, Jeff Cody, 2013/04/23
- [Qemu-devel] [PATCH v2 2/5] block: vhdx header for the QEMU support of VHDX images, Jeff Cody, 2013/04/23
- [Qemu-devel] [PATCH v2 3/5] block: initial VHDX driver support framework - supports open and probe, Jeff Cody, 2013/04/23
- Re: [Qemu-devel] [PATCH v2 3/5] block: initial VHDX driver support framework - supports open and probe, Stefan Hajnoczi, 2013/04/24
- Re: [Qemu-devel] [PATCH v2 3/5] block: initial VHDX driver support framework - supports open and probe, Kevin Wolf, 2013/04/25