[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/32] lsi: use qdev_reset_all
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 03/32] lsi: use qdev_reset_all |
|
Date: |
Tue, 23 Apr 2013 18:43:16 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
Il 23/04/2013 18:13, Paolo Bonzini ha scritto:
> Il 23/04/2013 10:47, Jan Kiszka ha scritto:
>>>> if (val & LSI_ISTAT0_SRST) {
>>>> - lsi_soft_reset(s);
>>>> + qdev_reset_all(&s->dev.qdev);
>> What should ensure that all device resets are performed before the host
>> reset? I'm asking as we just ran into the assert(!s->current) over
>> 1.3.1. Or is there some patch from a later version missing (not seeing
>> anything suspicious for lsi at least)?
>
> qdev should, but it looks like it uses pre-order instead of post-order.
Something like this series (based on 1.3.0), totally untested.
Paolo
reset-for-jan.patch
Description: Text Data