Re: [Qemu-devel] [PATCH 1/6] target-i386/seg_helper: replace env->eip with EIP

[li guang]

在 2013-04-19五的 09:48 +0200，Richard Henderson写道：
> On 2013-04-19 04:52, liguang wrote:
> > Signed-off-by: liguang <address@hidden>
> > ---
> >   target-i386/seg_helper.c |   46 
> > +++++++++++++++++++++++-----------------------
> >   1 files changed, 23 insertions(+), 23 deletions(-)
> >
> > diff --git a/target-i386/seg_helper.c b/target-i386/seg_helper.c
> > index 906e4f3..5f7f99d 100644
> > --- a/target-i386/seg_helper.c
> > +++ b/target-i386/seg_helper.c
> > @@ -388,7 +388,7 @@ static void switch_tss(CPUX86State *env, int 
> > tss_selector,
> >
> >       /* load all registers without an exception, then reload them with
> >          possible exception */
> > -    env->eip = new_eip;
> > +    EIP = new_eip;
> 
> IMO this is not a cleanup, and we should in fact be doing the exact opposite,
> getting rid of those silly macros.
> 

Yes, I have the same feeling.
do you think we can also get rid of ESP, EBP, ...?