[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [qom-cpu PATCH 2/7] target-i386/kvm.c: Code formatting
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [qom-cpu PATCH 2/7] target-i386/kvm.c: Code formatting changes |
Date: |
Tue, 16 Apr 2013 16:23:07 +0200 |
On Mon, 15 Apr 2013 16:25:35 -0300
Eduardo Habkost <address@hidden> wrote:
> Add appropriate spaces around operators, and break line where it needs
> to be broken to allow feature-words array to be introduced without
> having too-long lines.
>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> target-i386/kvm.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> index 397afeb..375219a 100644
> --- a/target-i386/kvm.c
> +++ b/target-i386/kvm.c
> @@ -610,7 +610,8 @@ int kvm_arch_init_vcpu(CPUState *cs)
> cpuid_data.cpuid.nent = cpuid_i;
>
> if (((env->cpuid_version >> 8)&0xF) >= 6
> - && (env->cpuid_features&(CPUID_MCE|CPUID_MCA)) ==
> (CPUID_MCE|CPUID_MCA)
> + && (env->cpuid_features & (CPUID_MCE|CPUID_MCA)) ==
> + (CPUID_MCE|CPUID_MCA)
small nit, ^ perhaps better to align it along with statement above
> && kvm_check_extension(cs->kvm_state, KVM_CAP_MCE) > 0) {
> uint64_t mcg_cap;
> int banks;
Reviewed-By: Igor Mammedov <address@hidden>
- [Qemu-devel] [qom-cpu PATCH 0/7] replace cpuid_*features fields with a featue word array (v8), Eduardo Habkost, 2013/04/15
- [Qemu-devel] [qom-cpu PATCH 3/7] target-i386: Move xlevel/xlevel2 in struct x86_def_t, Eduardo Habkost, 2013/04/15
- [Qemu-devel] [qom-cpu PATCH 2/7] target-i386/kvm.c: Code formatting changes, Eduardo Habkost, 2013/04/15
- Re: [Qemu-devel] [qom-cpu PATCH 2/7] target-i386/kvm.c: Code formatting changes,
Igor Mammedov <=
- [Qemu-devel] [qom-cpu PATCH 4/7] target-i386/cpu.c: Break lines on kvm_cpu_fill_host(), Eduardo Habkost, 2013/04/15
- [Qemu-devel] [qom-cpu PATCH 5/7] target-i386/cpu.c: Break lines on kvm_check_features_against_host(), Eduardo Habkost, 2013/04/15
- [Qemu-devel] [qom-cpu PATCH 1/7] target-i386: Move cpuid_xlevel, cpuid_xlevel2 fields in X86CPU, Eduardo Habkost, 2013/04/15
- [Qemu-devel] [qom-cpu PATCH 6/7] target-i386/cpu.c: Break lines on builtin_x86_defs array, Eduardo Habkost, 2013/04/15
- [Qemu-devel] [qom-cpu PATCH 7/7] target-i386: Replace cpuid_*features fields with a feature word array, Eduardo Habkost, 2013/04/15