qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 14/15] block: Remove filename parameter from .bd


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 14/15] block: Remove filename parameter from .bdrv_file_open()
Date: Mon, 15 Apr 2013 14:47:13 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5

On 04/12/2013 02:48 PM, Kevin Wolf wrote:
> It is unused now in all block drivers.
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> +++ b/block/gluster.c
> @@ -296,8 +296,8 @@ static QemuOptsList runtime_opts = {
>      },
>  };
>  
> -static int qemu_gluster_open(BlockDriverState *bs, const char *dummy,
> -    QDict *options, int bdrv_flags)
> +static int qemu_gluster_open(BlockDriverState *bs,  QDict *options,
> +                             int bdrv_flags)

Ah, one of my comments about inconsistent indentation in 9/15 has been
solved here (so it's fine to avoid the churn of touching it up twice).

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]