[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 14/15] block: Remove filename parameter from .bd
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 14/15] block: Remove filename parameter from .bdrv_file_open() |
Date: |
Mon, 15 Apr 2013 14:47:13 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5 |
On 04/12/2013 02:48 PM, Kevin Wolf wrote:
> It is unused now in all block drivers.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> +++ b/block/gluster.c
> @@ -296,8 +296,8 @@ static QemuOptsList runtime_opts = {
> },
> };
>
> -static int qemu_gluster_open(BlockDriverState *bs, const char *dummy,
> - QDict *options, int bdrv_flags)
> +static int qemu_gluster_open(BlockDriverState *bs, QDict *options,
> + int bdrv_flags)
Ah, one of my comments about inconsistent indentation in 9/15 has been
solved here (so it's fine to avoid the churn of touching it up twice).
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 09/15] gluster: Use bdrv_open options instead of filename, (continued)
- [Qemu-devel] [PATCH 10/15] iscsi: Use bdrv_open options instead of filename, Kevin Wolf, 2013/04/12
- [Qemu-devel] [PATCH 11/15] rbd: Use bdrv_open options instead of filename, Kevin Wolf, 2013/04/12
- [Qemu-devel] [PATCH 12/15] sheepdog: Use bdrv_open options instead of filename, Kevin Wolf, 2013/04/12
- [Qemu-devel] [PATCH 13/15] vvfat: Use bdrv_open options instead of filename, Kevin Wolf, 2013/04/12
- [Qemu-devel] [PATCH 14/15] block: Remove filename parameter from .bdrv_file_open(), Kevin Wolf, 2013/04/12
- [Qemu-devel] [PATCH 15/15] block: Allow overriding backing.file.filename, Kevin Wolf, 2013/04/12
- Re: [Qemu-devel] [PATCH 00/15] block: Overriding the backing file with -drive, Stefan Hajnoczi, 2013/04/18