qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 09/15] gluster: Use bdrv_open options instead of


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 09/15] gluster: Use bdrv_open options instead of filename
Date: Mon, 15 Apr 2013 14:07:22 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5

On 04/12/2013 02:48 PM, Kevin Wolf wrote:
> This is only to convert the internal interface that is used for passing
> the "filename" to be parsed, but converting to actual fine grained
> options is left for another day, as it doesn't look trivial.
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block/gluster.c | 32 +++++++++++++++++++++++++++++++-
>  1 file changed, 31 insertions(+), 1 deletion(-)
> 
> +
> +static int qemu_gluster_open(BlockDriverState *bs, const char *dummy,
>      QDict *options, int bdrv_flags)

As long as you are touching this code, should you re-indent the second
line of this signature?

> +
> +    filename = qemu_opt_get(opts, "filename");
> +
>  
>      s->glfs = qemu_gluster_init(gconf, filename);

Why the two blank lines?

Comments deal only with whitespace, so feel free to add:

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]