qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 04/15] raw-posix: Use bdrv_open options instead


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 04/15] raw-posix: Use bdrv_open options instead of filename
Date: Mon, 15 Apr 2013 11:52:26 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5

On 04/12/2013 02:47 PM, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block/raw-posix.c | 57 
> +++++++++++++++++++++++++++++++++++++++++++------------
>  1 file changed, 45 insertions(+), 12 deletions(-)

> +static int raw_open_common(BlockDriverState *bs, QDict *options,
>                             int bdrv_flags, int open_flags)
>  {
>      BDRVRawState *s = bs->opaque;
> +    QemuOpts *opts;
> +    Error *local_err = NULL;
> +    const char* filename;

Spacing is off for this line (should be before *, not after).  But
that's trivial, so I have no qualms with adding this to a fixed version:

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]