[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/19] cpu: introduce get_arch_id() method and o
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 08/19] cpu: introduce get_arch_id() method and override it for target-i386 |
Date: |
Mon, 15 Apr 2013 17:42:10 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 |
Am 15.04.2013 17:34, schrieb Igor Mammedov:
> On Mon, 15 Apr 2013 17:24:36 +0200
> Andreas Färber <address@hidden> wrote:
>
>> Am 11.04.2013 16:51, schrieb Igor Mammedov:
>>> get_arch_id() adds possibility for generic code to get guest visible
>>> CPI id without accessing CPUArchState. If target doesn't override it,
>>> it will return cpu_index.
>>>
>>> Override it on target-i386 to return APIC ID.
>>>
>>> Signed-off-by: Igor Mammedov <address@hidden>
>>> ---
>>> * it will be used later by new cpu_exists() generic function and
>>> acpi_piix.
>>> * s/cpu_firmware_id/cpu_arch_id/
>>> ---
>>> include/qom/cpu.h | 2 ++
>>> qom/cpu.c | 6 ++++++
>>> target-i386/cpu.c | 10 ++++++++++
>>> 3 files changed, 18 insertions(+)
>>
>> I'm still unclear about this ID topic, but please don't add QOM methods
>> with arch_ in the name. The arch is expressed through subclasses.
>
> arch is there to explicitly show that returned ID is defined by target and
> not generic code. This method then allow to implement cpu_exists() and helps
> to init present cpus bitmap in acpi_piix4.
>
> Would be cpu_id() acceptable?
Certainly.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- Re: [Qemu-devel] [PATCH 07/19] rtc: update rtc_cmos on CPU hot-plug, (continued)
- [Qemu-devel] [PATCH 09/19] cpu: add helper cpu_exists(), to check if CPU with specified id exists, Igor Mammedov, 2013/04/11
- [Qemu-devel] [PATCH 08/19] cpu: introduce get_arch_id() method and override it for target-i386, Igor Mammedov, 2013/04/11
- Re: [Qemu-devel] [PATCH 08/19] cpu: introduce get_arch_id() method and override it for target-i386, Andreas Färber, 2013/04/15
- Re: [Qemu-devel] [PATCH 08/19] cpu: introduce get_arch_id() method and override it for target-i386, Eduardo Habkost, 2013/04/15
- Re: [Qemu-devel] [PATCH 08/19] cpu: introduce get_arch_id() method and override it for target-i386, Igor Mammedov, 2013/04/15
[Qemu-devel] [PATCH 10/19] acpi_piix4: add infrastructure to send CPU hot-plug GPE to guest, Igor Mammedov, 2013/04/11
[Qemu-devel] [PATCH 11/19] target-i386: introduce apic-id property, Igor Mammedov, 2013/04/11
- Re: [Qemu-devel] [PATCH 11/19] target-i386: introduce apic-id property, Eduardo Habkost, 2013/04/11
- Re: [Qemu-devel] [PATCH 11/19] target-i386: introduce apic-id property, Igor Mammedov, 2013/04/12
- Re: [Qemu-devel] [PATCH 11/19] target-i386: introduce apic-id property, Eduardo Habkost, 2013/04/12
- Re: [Qemu-devel] [PATCH 11/19] target-i386: introduce apic-id property, Igor Mammedov, 2013/04/12
- Re: [Qemu-devel] [PATCH 11/19] target-i386: introduce apic-id property, Eduardo Habkost, 2013/04/12
- Re: [Qemu-devel] [PATCH 11/19] target-i386: introduce apic-id property, li guang, 2013/04/14