Re: [Qemu-devel] [PATCH] mainloop.c: Keep unlocking BQL during busy-wait spin-out

[Anthony Liguori]

Paolo Bonzini <address@hidden> writes:

> Il 15/04/2013 15:08, Anthony Liguori ha scritto:
>>> > Signed-off-by: Peter Crosthwaite <address@hidden>
>> I'm going through patches for 1.5 candidates.
>> 
>> I believe the paste performance issue has been resolved now and this
>> patch is no longer needed.  I can't find a definitive statement on the
>> list for that though.
>> 
>> Peter, can you confirm?
>
> Kind of.
>
> There is one remaining patch,

Yeah, I'm testing this right now.

> http://article.gmane.org/gmane.comp.emulators.qemu/205376.  Amit says he
> sees a problem with it, but I cannot reproduce.  But the patch is
> obvious and the problem must be latent, so I would apply it anyway.

So far, I haven't encountered a problem with it and that includes doing
virtio-serial testing.  If I don't see a problem, I'll push it as I
agree the patch looks obviously correct to me.

> There is another issue pointed out by Michael Hines with "-serial pty".
>  I couldn't reproduce it, but I haven't tried very hard.

There's also a qtest problem that Andreas reported that I can reproduce
that I have already begun looking into.

Regards,

Anthony Liguori

>
> Paolo