[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-arm: Reinsert SRS missing return stateme
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] target-arm: Reinsert SRS missing return statements. |
Date: |
Mon, 15 Apr 2013 08:23:21 +0100 |
On 15 April 2013 05:50, Peter Chubb <address@hidden> wrote:
>
>
> Since patch
> 81465888c5306cd94abb9847e560796fd13d3c2f
> target-arm: factor out handling of SRS instruction
> the SRS instruction has not worked in QEMU.
>
> The problem is a return directive that was removed in the
> refactoring, so after decoding the instruction, qemu would fall
> through to do stuff that it should not have done.
Nice catch for the ARM decoder, but not needed for thumb2
I think?
thanks
-- PMM