[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protoc
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation |
Date: |
Fri, 12 Apr 2013 16:43:54 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
Il 12/04/2013 13:25, Michael S. Tsirkin ha scritto:
> On Fri, Apr 12, 2013 at 12:53:11PM +0200, Paolo Bonzini wrote:
>> Il 12/04/2013 12:48, Michael S. Tsirkin ha scritto:
>>> 1. You have two protocols already and this does not make sense in
>>> version 1 of the patch.
>>
>> It makes sense if we consider it experimental (add x- in front of
>> transport and capability) and would like people to play with it.
>>
>> Paolo
>
> But it's not testable yet. I see problems just reading the
> documentation. Author thinks "ulimit -l 10000000000" on both source and
> destination is just fine. This can easily crash host or cause OOM
> killer to kill QEMU. So why is there any need for extra testers? Fix
> the major bugs first.
>
> There's a similar issue with device assignment - we can't fix it there,
> and despite being available for years, this was one of two reasons that
> has kept this feature out of hands of lots of users (and assuming guest
> has lots of zero pages won't work: balloon is not widely used either
> since it depends on a well-behaved guest to work correctly).
I agree assuming guest has lots of zero pages won't work, but I think
you are overstating the importance of overcommit. Let's mark the damn
thing as experimental, and stop making perfect the enemy of good.
Paolo
- Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation, (continued)
- Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation, Michael S. Tsirkin, 2013/04/11
- Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation, Paolo Bonzini, 2013/04/11
- Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation, Michael R. Hines, 2013/04/11
- Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation, Michael S. Tsirkin, 2013/04/11
- Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation, Michael R. Hines, 2013/04/11
- Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation, Michael S. Tsirkin, 2013/04/11
- Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation, Michael R. Hines, 2013/04/11
- Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation, Michael S. Tsirkin, 2013/04/12
- Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation, Paolo Bonzini, 2013/04/12
- Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation, Michael S. Tsirkin, 2013/04/12
- Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation,
Paolo Bonzini <=
- Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation, Michael S. Tsirkin, 2013/04/14
- Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation, Paolo Bonzini, 2013/04/14
- Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation, Michael R. Hines, 2013/04/14
- Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation, Michael R. Hines, 2013/04/14
- Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation, Michael S. Tsirkin, 2013/04/14
- Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation, Michael R. Hines, 2013/04/14
- Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation, Michael R. Hines, 2013/04/14
- Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation, Michael S. Tsirkin, 2013/04/14
- Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation, Michael R. Hines, 2013/04/14
- Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation, Michael S. Tsirkin, 2013/04/14