Re: [Qemu-devel] [PATCH 2/8] rdma: core rdma logic

[Paolo Bonzini]

Il 12/04/2013 07:52, address@hidden ha scritto:
> 
> + *
> + * If we're using dynamic registration on the server-side, we have to
> + * send a registration command first.
> + */
> +static int __qemu_rdma_write(QEMUFile *f, RDMAContext *rdma,
> +        int current_index,
> +        uint64_t offset, uint64_t length,
> +        uint64_t wr_id, enum ibv_send_flags flag)
> +{

No __ prefix, perhaps call this function qemu_rdma_flush_one?

> +    /*
> +     * Don't pin zero pages on the destination. Just return.
> +     */
> +    if (rdma->chunk_register_destination &&
> +            (buffer_find_nonzero_offset(va, size) == size)) {
> +        return size;
> +    }

Is this the right place to test?  Is it correct if a page first is
non-zero and then becomes zero?  Perhaps you have to test where you add
a page to a chunk, instead.

Paolo