[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots |
Date: |
Thu, 11 Apr 2013 21:22:06 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5 |
On 04/11/2013 09:17 PM, Wenchao Xia wrote:
>>
>>> Hmm, as I typed that, I did another search of qemu-schema.json - we have
>>> the type 'ImageInfo' defined, but none of the existing 'command's ever
>>> call out the use of that type. Is it a type we are only using
>>> internally to date, and where this is the first QMP command that would
>>> actually expose SnapshotInfo or ImageInfo to a management app? Then
>>> maybe we _CAN_ modify SnapshotInfo, clean up all the internal code, and
>>> provide a saner type for the first time that QMP can actually use it.
>>
>> IIRC, it's being used by qemu-img. As it's not trivial to determine if
>> the field has users and as what goes in the schema is to be considered
>> stable,
>> it's better to keep the field. Instead, we could add a better field and
>> deprecate the current one.
>>
> I remember there is a patch laster year made "qemu-img info" dump out
> json strings, where vm-clock-sec is dumped out.
Ah, so it's not QMP exposing it, but qemu-info in JSON mode. Still,
changing that output to delete a field might break existing tools;
adding a field might be safer, but then you'd have redundant information
in the old style for old tools, as well as the added field.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH V11 08/17] block: move qmp_query_block() and bdrv_query_info() to block/qapi.c, (continued)
- [Qemu-devel] [PATCH V11 08/17] block: move qmp_query_block() and bdrv_query_info() to block/qapi.c, Wenchao Xia, 2013/04/02
- [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots, Wenchao Xia, 2013/04/02
- Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots, Stefan Hajnoczi, 2013/04/08
- Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots, Markus Armbruster, 2013/04/10
- Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots, Wenchao Xia, 2013/04/11
- Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots, Markus Armbruster, 2013/04/11
- Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots, Luiz Capitulino, 2013/04/11
- Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots, Eric Blake, 2013/04/11
- Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots, Luiz Capitulino, 2013/04/11
- Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots, Wenchao Xia, 2013/04/11
- Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots,
Eric Blake <=
- Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots, Wenchao Xia, 2013/04/12
- Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots, Markus Armbruster, 2013/04/12
[Qemu-devel] [PATCH V11 10/17] qmp: add recursive member in ImageInfo, Wenchao Xia, 2013/04/02
[Qemu-devel] [PATCH V11 07/17] block: add image info query function bdrv_query_image_info(), Wenchao Xia, 2013/04/02
[Qemu-devel] [PATCH V11 12/17] block: move bdrv_snapshot_dump() and dump_human_image_info() to block/qapi.c, Wenchao Xia, 2013/04/02