Re: [Qemu-devel] [PATCH 00/16] minially change gen_intermediate_code_internal function

[Peter Maydell]

On 11 April 2013 04:41, li guang <address@hidden> wrote:
> here are instructions in the finial qemu-system-x86
> before and after my chanage, you can easily find a
> redundant 'addl' was removed

Yes, but:
 * the removed instruction is not inside the loop
 * the entire loop is not in a speed critical path
 * removing an addl will save a cycle or two
 * the specific syntax used for this loop is far from
   the hardest barrier to understanding what the search_pc
   code is actually doing

Is it really worth the code churn?

It would be more interesting to find a better interface
between the common parts of QEMU and the target code
so that there's less repetition in these target functions
in the first place.

thanks
-- PMM