[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH RDMA support v1: 10/13] introduce new comman
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RFC PATCH RDMA support v1: 10/13] introduce new command migrate_check_for_zero |
Date: |
Wed, 10 Apr 2013 20:26:16 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5 |
On 04/10/2013 04:28 PM, address@hidden wrote:
> From: "Michael R. Hines" <address@hidden>
>
> This allows the user to disable zero page checking during migration
>
> Signed-off-by: Michael R. Hines <address@hidden>
> ---
> +++ b/qapi-schema.json
> @@ -1792,6 +1792,19 @@
> { 'command': 'migrate_set_downtime', 'data': {'value': 'number'} }
>
> ##
> +# @migrate_check_for_zero
> +#
> +# Control whether or not to check for zero pages during migration.
New QMP commands should be named with '-' rather than '_', as in
'migrate-check-for-zero'.
Why do we need a new command, instead of adding a new capability to the
already-existing capability command?
> +#
> +# @value: on|off
> +#
> +# Returns: nothing on success
> +#
> +# Since: 1.5.0
> +##
> +{ 'command': 'migrate_check_for_zero', 'data': {'value': 'bool'} }
You can set the capability, but how do you query its current setting? I
dislike write-only interfaces.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [RFC PATCH RDMA support v7: 00/13] rdma cleanup and reordering, mrhines, 2013/04/10
- [Qemu-devel] [RFC PATCH RDMA support v1: 01/13] introduce qemu_ram_foreach_block(), mrhines, 2013/04/10
- [Qemu-devel] [RFC PATCH RDMA support v1: 05/13] accessor function prototypes for new QEMUFileOps hooks, mrhines, 2013/04/10
- [Qemu-devel] [RFC PATCH RDMA support v1: 06/13] implementation of new QEMUFileOps hooks, mrhines, 2013/04/10
- [Qemu-devel] [RFC PATCH RDMA support v1: 07/13] introduce capability for dynamic chunk registration, mrhines, 2013/04/10
- [Qemu-devel] [RFC PATCH RDMA support v1: 04/13] update QEMUFileOps with new hooks, mrhines, 2013/04/10
- [Qemu-devel] [RFC PATCH RDMA support v1: 08/13] default chunk registration to true, mrhines, 2013/04/10
- [Qemu-devel] [RFC PATCH RDMA support v1: 10/13] introduce new command migrate_check_for_zero, mrhines, 2013/04/10
- Re: [Qemu-devel] [RFC PATCH RDMA support v1: 10/13] introduce new command migrate_check_for_zero,
Eric Blake <=
- Re: [Qemu-devel] [RFC PATCH RDMA support v1: 10/13] introduce new command migrate_check_for_zero, Michael R. Hines, 2013/04/10
- Re: [Qemu-devel] [RFC PATCH RDMA support v1: 10/13] introduce new command migrate_check_for_zero, Orit Wasserman, 2013/04/11
- Re: [Qemu-devel] [RFC PATCH RDMA support v1: 10/13] introduce new command migrate_check_for_zero, Eric Blake, 2013/04/11
- Re: [Qemu-devel] [RFC PATCH RDMA support v1: 10/13] introduce new command migrate_check_for_zero, Orit Wasserman, 2013/04/11
- Re: [Qemu-devel] [RFC PATCH RDMA support v1: 10/13] introduce new command migrate_check_for_zero, Michael R. Hines, 2013/04/11
- Re: [Qemu-devel] [RFC PATCH RDMA support v1: 10/13] introduce new command migrate_check_for_zero, Michael R. Hines, 2013/04/10
Re: [Qemu-devel] [RFC PATCH RDMA support v1: 10/13] introduce new command migrate_check_for_zero, Michael S. Tsirkin, 2013/04/11