[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] i.MX: implement a more correct version of EPIT
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] i.MX: implement a more correct version of EPIT timer. |
Date: |
Wed, 10 Apr 2013 09:26:13 +0100 |
On 9 April 2013 23:32, Jean-Christophe DUBOIS <address@hidden> wrote:
> @@ -605,11 +735,13 @@ static const VMStateDescription vmstate_imx_timerp = {
> .minimum_version_id_old = 1,
> .fields = (VMStateField[]) {
> VMSTATE_UINT32(cr, IMXTimerPState),
> + VMSTATE_UINT32(sr, IMXTimerPState),
> VMSTATE_UINT32(lr, IMXTimerPState),
> VMSTATE_UINT32(cmp, IMXTimerPState),
> + VMSTATE_UINT32(cnt, IMXTimerPState),
> VMSTATE_UINT32(freq, IMXTimerPState),
> - VMSTATE_INT32(int_level, IMXTimerPState),
> - VMSTATE_PTIMER(timer, IMXTimerPState),
> + VMSTATE_PTIMER(timer_reload, IMXTimerPState),
> + VMSTATE_PTIMER(timer_cmp, IMXTimerPState),
> VMSTATE_END_OF_LIST()
> }
> };
If you're adding/changing vmstate fields like this then you
need to increment all the version id fields too. Otherwise
cross-version migration will break oddly (rather than failing
cleanly).
thanks
-- PMM