Re: [Qemu-devel] [RFC PATCH RDMA support v5: 07/12] additional savevm.c accessors for RDMA

[Michael R. Hines]

On 04/09/2013 01:31 PM, Peter Maydell wrote:
> On 9 April 2013 04:04,  <address@hidden> wrote:
> > From: "Michael R. Hines" <address@hidden>
> >
> > 1. qemu_file_ops_are()
> > 2. qemu_file_update_position()    (for f->pos)
> >
> > Also need to be here:
> > rdma_read_ops
> > rdma_write_ops

My apologies..... will do =)

> Do you think you could try to expand on your commit messages
> a bit? The idea is that a commit message should generally
> give an overview of the patch including rationale; it should
> be reasonably meaningful if you look only at the commit
> message and not the patch itself. This one has a very
> abbreviated description of the "what" and is missing any
> kind of "why".
>
> thanks
> -- PMM