|
| From: | Peter Maydell |
| Subject: | Re: [Qemu-devel] [RFC PATCH RDMA support v5: 07/12] additional savevm.c accessors for RDMA |
| Date: | Tue, 9 Apr 2013 18:31:47 +0100 |
On 9 April 2013 04:04, <address@hidden> wrote: > From: "Michael R. Hines" <address@hidden> > > 1. qemu_file_ops_are() > 2. qemu_file_update_position() (for f->pos) > > Also need to be here: > rdma_read_ops > rdma_write_ops Do you think you could try to expand on your commit messages a bit? The idea is that a commit message should generally give an overview of the patch including rationale; it should be reasonably meaningful if you look only at the commit message and not the patch itself. This one has a very abbreviated description of the "what" and is missing any kind of "why". thanks -- PMM
| [Prev in Thread] | Current Thread | [Next in Thread] |