[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] linux-user: fix setgroups/getgroups for non-UID16 a
From: |
Andreas Schwab |
Subject: |
[Qemu-devel] [PATCH] linux-user: fix setgroups/getgroups for non-UID16 archs |
Date: |
Tue, 09 Apr 2013 17:41:33 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Don't assume target_id is a short.
Signed-off-by: Andreas Schwab <address@hidden>
---
linux-user/syscall.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index d3c26de..3f13d0b 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -7800,12 +7800,12 @@ abi_long do_syscall(void *cpu_env, int num, abi_long
arg1,
if (gidsetsize == 0)
break;
if (!is_error(ret)) {
- target_grouplist = lock_user(VERIFY_WRITE, arg2, gidsetsize *
2, 0);
+ target_grouplist = lock_user(VERIFY_WRITE, arg2, gidsetsize *
sizeof(target_id), 0);
if (!target_grouplist)
goto efault;
for(i = 0;i < ret; i++)
target_grouplist[i] = tswapid(high2lowgid(grouplist[i]));
- unlock_user(target_grouplist, arg2, gidsetsize * 2);
+ unlock_user(target_grouplist, arg2, gidsetsize *
sizeof(target_id));
}
}
break;
@@ -7817,7 +7817,7 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
int i;
if (gidsetsize) {
grouplist = alloca(gidsetsize * sizeof(gid_t));
- target_grouplist = lock_user(VERIFY_READ, arg2, gidsetsize *
2, 1);
+ target_grouplist = lock_user(VERIFY_READ, arg2, gidsetsize *
sizeof(target_id), 1);
if (!target_grouplist) {
ret = -TARGET_EFAULT;
goto fail;
--
1.8.2.1
--
Andreas Schwab, SUSE Labs, address@hidden
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-devel] [PATCH] linux-user: fix setgroups/getgroups for non-UID16 archs,
Andreas Schwab <=