qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/6] iov: reorganize iov_send_recv, part 1


From: Juan Quintela
Subject: Re: [Qemu-devel] [PATCH 2/6] iov: reorganize iov_send_recv, part 1
Date: Tue, 09 Apr 2013 15:18:58 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux)

Paolo Bonzini <address@hidden> wrote:
> Once the initial part of the iov is dropped, it is not used anymore.
> Modify iov/iovcnt directly instead of adjusting them with the "si"
> variable.
>
> Signed-off-by: Paolo Bonzini <address@hidden>


I would have preffered that iov was used as const,  but as the current
code already modifies it,  nothing wrong here.

(coping the iov shouldn't have been such a big problem and we would
remove the need to fix the offsets at the end).

But as said,  code is better than what we had.

Reviewed-by: Juan Quintela <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]