qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/4] migration: use a single I/O operation when


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 2/4] migration: use a single I/O operation when writev_buffer is not defined
Date: Tue, 09 Apr 2013 13:42:48 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4

Il 09/04/2013 13:38, Juan Quintela ha scritto:
> And this
> 
> 
> 
> is not needed if we just put the code inside add_to_iovec() no?
> 
> Users of add_to_iovec() should not care if we are using vritev or
> put_buffer() right.

I'm taking the opposite stance here.  add_to_iovec() should not be
called at all if using put_buffer.

> and as a second note.  Having qemu_put_buffer_async() calling
> qemu_put_buffer() and qemu_put_buffer() calling qemu_put_buffer_async()
> is ..... weird?

Yes, in fact after this patch qemu_put_buffer() is not calling
qemu_put_buffer_async() anymore.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]