[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vga.c: move debug printfs to trace events
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH] vga.c: move debug printfs to trace events |
|
Date: |
Mon, 8 Apr 2013 16:15:23 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Apr 03, 2013 at 12:25:03PM +0300, Alex DAMIAN wrote:
> @@ -390,9 +386,7 @@ uint32_t vga_ioport_read(void *opaque, uint32_t addr)
> break;
> case VGA_SEQ_D:
> val = s->sr[s->sr_index];
> -#ifdef DEBUG_VGA_REG
> - printf("vga: read SR%x = 0x%02x\n", s->sr_index, val);
> -#endif
> + trace_vga_register_read("SR", s->sr_index, val);
A tab crept in here. Please use 4 spaces for indentation.
Looks good otherwise.
Stefan