Re: [Qemu-devel] [PATCH v2 05/10] elfload: use abi_int/uint instead of target_int/uint

[Paolo Bonzini]

Il 04/04/2013 16:22, Peter Maydell ha scritto:
>> >
>> > That would create 10 empty files, and two files between one and three
>> > lines of code.  I would just put those in include/exec/user/abitypes.h.
> I would prefer not to add more code with TARGET ifdefs.
> (I have a vague plan to split up some of the current linux-user
> code which is #ifdefs in source files in linux-user into per
> target source files which make just pulls in as appropriate.)
> 
> Also, separate files in linux-user/foo encourage authors of
> new targets to think "do I need to put something in my new
> target's version of this?" whereas #ifdef TARGET_FOO in
> common source files don't.

I can't deny these are all good arguments.  I'm not sure if abitypes
would be the best or the worst place to start doing this conversion.

Paolo

> Riku's the linux-user maintainer, though...