Re: [Qemu-devel] [PATCHv2 0/6] ARM dump-guest-memory support

[Andreas Färber]

Am 29.03.2013 09:36, schrieb Rabin Vincent:
> 2013/3/25 Andreas Färber <address@hidden>
>> This still does not address the architectural issue that I brought up.
> 
> I guess you mean the CPUArchState stuff?  AFAICS Wen Congyang (the
> author of the dump code) had some answers/questions for you:
> 
> http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg00382.html
> http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg00384.html

Yes, that is what I'm referring to, and I don't see answers to my
questions...

If as I understand we are talking about a property that depends solely
on the target CPU then it should be implemented on CPUClass level (which
is the one above ARMCPU, S390CPU etc.) and not require changes to
configure at all. CPUArchState is by contrast a per-target type.
qom/cpu.c would implement the dummy versions and in your case
target-arm/cpu.c (in Jens' case target-s390x/cpu.c) should override that
behavior by setting cc->whatever to a static function that actually
implements the functionality. I would supply you with a patch for that
myself, but I am rather busy with downstream ATM and Igor is poking me
for x86 CPU review, so if either of you or Wen Congyang could fix that
design flaw before making it worse I would appreciate that!

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg