Re: [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions

[Anthony Liguori]

Paolo Bonzini <address@hidden> writes:

> Il 21/03/2013 13:42, Laszlo Ersek ha scritto:
>> On 03/21/13 13:36, Michael S. Tsirkin wrote:
>>> On Thu, Mar 21, 2013 at 12:51:34PM +0100, Paolo Bonzini wrote:
>>>> Il 21/03/2013 11:41, Laszlo Ersek ha scritto:
>>>>> On 03/21/13 01:31, Laszlo Ersek wrote:
>>>>>> On 03/21/13 00:45, Eric Blake wrote:
>>>>>>> On 03/20/2013 05:23 PM, Laszlo Ersek wrote:
>>>>>
>>>>>>>> +#
>>>>>>>> +# @oem_id: #optional OEM identifier (6 bytes)
>>>>>>>
>>>>>>> s/oem_id/oem-id/
>>>>>>>
>>>>>>> In general, new QMP interfaces should use '-', not '_'.
>>>>>>
>>>>>> Indeed! I think this warrants a respin.
>>>>>
>>>>> Actually it doesn't, apologies -- I got confused for a minute. Again,
>>>>> since I aim to match the existing option format, I must keep the same
>>>>> spelling.
>>>>
>>>> We should make a list of places where we have mixed conventions, accept
>>>> both, and mass-convert to dash...
>>>>
>>>> Paolo
>>>
>>> Anthony used to nack all mass conversions since they mess up the git
>>> history. Since the movement of headers went in, I gather this position
>>> has been relaxed...
>>>
>> 
>> Paolo, what are you suggesting precisely?
>
> Using something like
>
> int strcmp_dash(const char *a, const char *b)
> {
>     char p, q;
>     for (;; a++, b++) {
>         p = *a == '_' ? '-' : *a;
>         q = *b == '_' ? '-' : *b;
>         a++, b++;
>     } while (p == q && p != 0);
>     return p - q;
> }
>
> in QemuOpts, the monitor, etc.  The mass conversion isn't really
> necessary, just for cleanliness.

I had thought we already did this for qemu-option.c but it doesn't
appear that we do...

Regards,

Anthony Liguori

>
> Paolo