[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vmware_vga: do not cache depth and bypp
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH] vmware_vga: do not cache depth and bypp |
Date: |
Wed, 03 Apr 2013 11:49:36 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130307 Thunderbird/17.0.3 |
On 03/29/13 17:28, Alex DAMIAN wrote:
> From: Alexandru DAMIAN <address@hidden>
>
> Do not cache depth and bypp information in the device state.
>
> This resolves a bug where Xorg video-vmare driver refuses
> to start up because the depth value read is the one cached from the
> device start (default 32 from ui/console.c) and it is not consistent
> with the graphical console depth, which may be different from
> the default depth.
Does it actually work? /me posted a simliar patch and according to Jan
(Cc'ed) it doesn't fix the issue.
> @@ -1113,7 +1111,6 @@ static const VMStateDescription
> vmstate_vmware_vga_internal = {
> .minimum_version_id_old = 0,
> .post_load = vmsvga_post_load,
> .fields = (VMStateField[]) {
> - VMSTATE_INT32_EQUAL(depth, struct vmsvga_state_s),
This breaks live migration.
cheers,
Gerd
- Re: [Qemu-devel] [PATCH] vmware_vga: do not cache depth and bypp,
Gerd Hoffmann <=