[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/3] virtio/vhost: Add checks for uninitialized
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH 0/3] virtio/vhost: Add checks for uninitialized VQs |
Date: |
Sun, 31 Mar 2013 10:46:00 +0300 |
On Fri, Mar 29, 2013 at 04:33:09AM +0000, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger <address@hidden>
>
> Hi folks,
>
> This series adds a virtio_queue_valid() for use by virtio-pci code in
> order to prevent opreations upon uninitialized VQs, that is currently
> expected to occur during seabios setup of virtio-scsi.
>
> This also includes a vhost specific check for uninitialized VQs in
> vhost_verify_ring_mappings() to avoid this same case.
>
> Please review.
>
> --nab
Okay, and does this fix the failures in vhost_verify_ring_mappings
that you've observed?
> Michael S. Tsirkin (1):
> virtio: add API to check that ring is setup
>
> Nicholas Bellinger (2):
> virtio-pci: Add virtio_queue_valid checks ahead of
> virtio_queue_get_num
> vhost: Check+skip uninitialized VQs in vhost_verify_ring_mappings
>
> hw/vhost.c | 3 +++
> hw/virtio-pci.c | 27 +++++++++++++++++++++++++++
> hw/virtio.c | 5 +++++
> hw/virtio.h | 1 +
> 4 files changed, 36 insertions(+), 0 deletions(-)
>
> --
> 1.7.2.5