[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Patch] fix /proc/self/maps output
From: |
H. Peter Anvin |
Subject: |
Re: [Qemu-devel] [Patch] fix /proc/self/maps output |
Date: |
Fri, 29 Mar 2013 15:35:40 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
On 03/29/2013 09:01 AM, Christophe Lyon wrote:
> Add a space at end of line when there is no filename to print, to
> conform to linux kernel format.
>
> Signed-off-by: Christophe Lyon <address@hidden>
> ---
> linux-user/syscall.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index a148d9f..3b0ca86 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -5016,7 +5016,7 @@ static int open_self_maps(void *cpu_env, int fd)
> " %c%c%c%c %08" PRIx64 " %02x:%02x %d%s%s\n",
> h2g(min), h2g(max), flag_r, flag_w,
> flag_x, flag_p, offset, dev_maj, dev_min, inode,
> - path[0] ? " " : "", path);
> + path[0] ? " " : " ", path);
> }
> }
>
Please move the fixed space into the format. Perhaps even use a %-123s
type format even...
-hpa