[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 08/20] tcg-arm: Implement deposit for armv7
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 08/20] tcg-arm: Implement deposit for armv7 |
|
Date: |
Thu, 28 Mar 2013 16:59:29 +0000 |
On 28 March 2013 16:22, Richard Henderson <address@hidden> wrote:
> On 03/28/2013 09:15 AM, Peter Maydell wrote:
>> What guarantees us that we won't see a length of 0?
>> The tcg/README description doesn't say that's invalid
>> and I don't think the optimize pass handles it (maybe I
>> missed it).
>
> We can patch the readme, and the asserts in tcg-op.h if you like.
That would be nice, but I think I was getting confused with
the other edge case (length == 32), which we do handle
correctly.
-- PMM
- Re: [Qemu-devel] [PATCH v3 05/20] tcg-arm: Handle constant arguments to add2/sub2, (continued)
[Qemu-devel] [PATCH v3 03/20] tcg-arm: Allow constant first argument to sub, Richard Henderson, 2013/03/28
[Qemu-devel] [PATCH v3 06/20] tcg-arm: Improve constant generation, Richard Henderson, 2013/03/28
[Qemu-devel] [PATCH v3 07/20] tcg-arm: Fold epilogue into INDEX_op_exit_tb, Richard Henderson, 2013/03/28
[Qemu-devel] [PATCH v3 08/20] tcg-arm: Implement deposit for armv7, Richard Henderson, 2013/03/28
[Qemu-devel] [PATCH v3 09/20] tcg-arm: Implement division instructions, Richard Henderson, 2013/03/28
[Qemu-devel] [PATCH v3 10/20] tcg-arm: Use TCG_REG_TMP name for the tcg temporary, Richard Henderson, 2013/03/28
[Qemu-devel] [PATCH v3 11/20] tcg-arm: Use R12 for the tcg temporary, Richard Henderson, 2013/03/28
[Qemu-devel] [PATCH v3 12/20] tcg-arm: Cleanup multiply subroutines, Richard Henderson, 2013/03/28
[Qemu-devel] [PATCH v3 13/20] tcg-arm: Cleanup tcg_out_goto_label, Richard Henderson, 2013/03/28
[Qemu-devel] [PATCH v3 14/20] tcg-arm: Cleanup goto_tb handling, Richard Henderson, 2013/03/28